chore: remove git modules for better internal experience #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
force-pushed
the
chore/remove-submodules
branch
from
4adca8a
to
fd950e1
Compare
CodSpeed Performance ReportMerging #3054 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the internal git submodules of
test262,babelandTypescript. These modules were giving more issues than benefits, especially in the website repository where we have some codegen. Working with git submodules was becoming very hostile.Instead, this PR adds a new
checkoutmethod in the coverage suite, and we use a simplegit cloneandgit reset --hardto use the revision we need to run our coverage against.Test Plan
This CI will fail because the
mainbranch still uses the old method. However, I run this locally and it worked like a charm. That's why I added.gitignoreinside the coverage folder.